data update #567
Merged
data update #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markushal
requested changes
Sep 27, 2024
ptxboa/data/2030_high.csv
Outdated
| @@ -9,14 +9,13 @@ key,parameter_code,process_code,flow_code,source_region_code,target_country_code | |||
| "CALOR,,LOHC-L,,",CALOR,,LOHC-L,,,33.33,kWh H2 (l)/kg,Linde | |||
| "CALOR,,NH3-L,,",CALOR,,NH3-L,,,5.199999999999999,kWh NH3 (l)/kg,Wikipedia with conversions | |||
| "CAPEX,AEL-EL,,,",CAPEX,AEL-EL,,,,1210.9576551357125,USD2023/kW, | |||
| "CAPEX,ATR,,,",CAPEX,ATR,,,,895.7895675646487,USD2023/kW,Oni et al. 2022 | |||
There was a problem hiding this comment.
Looks like all parameters for ATR and REGASATR (methane reconversion with and without regasification) have been removed. I suppose this was not intentional, as we still use these processes. I will check with Roman.
| @@ -65,30 +62,6 @@ key,region,process_res,process_ely,process_deriv,process_flh,value,source | |||
| "ARE,PV-FIX,SOEC-EL,NH3SYN,NH3-REC",ARE,PV-FIX,SOEC-EL,NH3SYN,NH3-REC,7008.0,öko | |||
| "ARE,PV-FIX,SOEC-EL,NH3SYN,NH3SYN",ARE,PV-FIX,SOEC-EL,NH3SYN,NH3SYN,4809.0,PTX Atlas | |||
| "ARE,PV-FIX,SOEC-EL,NH3SYN,SOEC-EL",ARE,PV-FIX,SOEC-EL,NH3SYN,SOEC-EL,4809.0,PTX Atlas | |||
| "ARE,PV-TRK,AEL-EL,,H2-COMP",ARE,PV-TRK,AEL-EL,,H2-COMP,6657.599999999999, | |||
There was a problem hiding this comment.
removing PTR-TRK is fine. But: do we use this flh data at all? I thought this has all been replaced by profile data and optimization results.
There was a problem hiding this comment.
yea, its still there for backwards compatibility
so I have to rename it in the source excel file again?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@markushal not sure if all the data came through correctly. I see some changes for DRI, but also some deletions for ATR (and in flh.csv a lot of expected deletions for PV-TRACK)